Use of “counterparty” is confusing

[fulldecent]

Griefing contracts use the word “punisher” and “counterparty” interchangeably.

Also, in the advertised use cases, both the seller and buyer will be a “counterparty” for different agreements related to the same transaction.

Lastly, “counterparty” has a natural meaning in commerce.

These reasons contribute to the word potentially being misunderstood.

Inconsistency and lack of clarity create a risk of users misunderstanding the operation of the product.

Recommendation: entirely abandon the use of “counterparty” and adopt “punisher” to improve clarity and concrete, literal prose.

References:

• Punisher example:

  erasure-protocol/contracts/modules/Griefing.sol

  Line 23 in 4a3d98c

  event Griefed(address punisher, address staker, uint256 punishment, uint256 cost, bytes message);

• Counterparty example:

  erasure-protocol/contracts/agreements/CountdownGriefing.sol

  Line 25 in 4a3d98c

  event Initialized(address operator, address staker, address counterparty, uint256 ratio, Griefing.RatioType ratioType, uint256 countdownLength, bytes metadata);

[thegostep]

I agree with the recommendation, but will slate for future release.