Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deploy chronicles to radix #529

Merged
merged 13 commits into from
May 21, 2024
Merged

feat: deploy chronicles to radix #529

merged 13 commits into from
May 21, 2024

Conversation

HavardNot
Copy link
Collaborator

@HavardNot HavardNot commented May 14, 2024 •
edited

Added deploy setup for hosting Chronicles Web in Radix:
https://web-chronicles-test.radix.equinor.com/
https://web-chronicles-prod.radix.equinor.com/

Currently using tags to push build requests to radix, feel free to add your own suggestions and opinions on how we should schedule releases to test and production 馃憤

EDIT: Added release to production in the publish:all script and configured Radix to deploy to test from main

@HavardNot HavardNot linked an issue May 14, 2024 that may be closed by this pull request
Deploy Chronicles to Radix #528
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 14, 2024 •
edited

鈿狅笍 No Changeset found

Latest commit: 1e2fdf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HavardNot HavardNot requested review from tormodAase, HaakonSvane and Jonas-Omdal and removed request for tormodAase May 14, 2024 13:27
@HavardNot HavardNot marked this pull request as draft May 14, 2024 13:46
@HavardNot HavardNot marked this pull request as ready for review May 15, 2024 06:30
@HaakonSvane
Copy link
Collaborator

HaakonSvane commented May 15, 2024 •
edited

I suggest following the repository-convention of releasing: pushing to prod when we merge the release PR.
This is also how the docs CI/CD are set up at the moment. Having web build in the same manner makes it much more predictable knowing that it behaves exactly the same for all our apps / packages
Would be something like

  • Build to TEST whenever we merge to main
  • Build to PROD whenever we merge the release PR

@tormodAase, @Jonas-Omdal what do you think?

HaakonSvane
HaakonSvane previously approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@HaakonSvane HaakonSvane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挴 馃挴
Looks fresh 馃憣
I think we should discuss how we want to release as you mentioned. Made a comment in the PR for it.

package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tormodAase
tormodAase previously approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@tormodAase tormodAase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HavardNot HavardNot dismissed stale reviews from tormodAase and HaakonSvane via 4687407 May 15, 2024 10:07
HaakonSvane
HaakonSvane approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@HaakonSvane HaakonSvane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks hella nice 馃憣 馃敟

@HavardNot HavardNot merged commit 9f57184 into main May 21, 2024
5 checks passed
@HavardNot HavardNot deleted the 528-deploy-chronicles-to-radix branch May 21, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaakonSvane HaakonSvane HaakonSvane approved these changes

@Jonas-Omdal Jonas-Omdal Awaiting requested review from Jonas-Omdal

@tormodAase tormodAase Awaiting requested review from tormodAase

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy Chronicles to Radix
3 participants
@HavardNot @HaakonSvane @tormodAase