Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast package #521

Closed
tormodAase opened this issue May 8, 2024 · 1 comment · Fixed by #530
Closed

Toast package #521

tormodAase opened this issue May 8, 2024 · 1 comment · Fixed by #530
Assignees
Labels
feature New functionality

Comments

@tormodAase
Copy link
Contributor

Package / App

Other

Description

Requirements from discussion with @HavardNot , @dansvend , @HaakonSvane , @Jonas-Omdal a few months ago:

  • Should be a separate package
  • To make it easy for our apps to switch over, the API should be similar to react-native-salute
  • @equinor/mad-core will consume the package and make it available to the apps
  • Preferably stackable
  • Preferably swipe to dismiss
  • Use react-native-toast-message if possible.

Alternatives

No response

Other info

No response

@tormodAase tormodAase added the feature New functionality label May 8, 2024
@tormodAase tormodAase self-assigned this May 8, 2024
@tormodAase
Copy link
Contributor Author

react-native-toast-message looks fine, but it has some limitations:

  • There's no support for multiple toasts at the same time (not sure if we wanted this).
  • There's no queueing system, meaning if you try to display a toast when a toast is already visible, you will never display the 2nd toast.

I'll try to build a queueing system on top of it

@tormodAase tormodAase linked a pull request May 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant