Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the WorkOrder Cell in mad-dfw #488

Open
Chibuzor-Nwemambu opened this issue Apr 12, 2024 · 2 comments · May be fixed by #491
Open

Improving the WorkOrder Cell in mad-dfw #488

Chibuzor-Nwemambu opened this issue Apr 12, 2024 · 2 comments · May be fixed by #491
Assignees
Labels
feature New functionality

Comments

@Chibuzor-Nwemambu
Copy link

Chibuzor-Nwemambu commented Apr 12, 2024

Package / App

MAD DFW

Description

In order to fully utilise the WorkOrder Cell in WO app, we would need additional two fields which should be optional:

State - which returns a string/JSX.Element
Property from filter - which returns a string/JSX.Element/number

Also i need the propertyrow to continue on a new line for cases, like on web, where the text is longer than the screen width

Alternatives

No response

Other info

Current custom workorder cell in the app, looks like this:
Screenshot 2024-04-12 at 11 28 56
Screenshot 2024-04-12 at 11 29 27

It would be nice to have something similar that accommodates the extra props.

@Chibuzor-Nwemambu Chibuzor-Nwemambu added the feature New functionality label Apr 12, 2024
@Sandtory Sandtory linked a pull request Apr 12, 2024 that will close this issue
@HaakonSvane
Copy link
Collaborator

What is the idea behind the state prop? The filtering prop assumes that the cell is filtered somewhere else in the app that implements it. For any app-specific fields like this, would it be better to maybe provide a additionalProperties prop that takes in a list of property row props that will be added to the bottom of the properties in the cell?

@Sandtory
Copy link
Contributor

@HaakonSvane I somewhat agree as the status prop that is already implemented covers the state, and that most of the functionality for the propertyfromfilter is made outside of the component so could maybe just do that and add an ´additionalProperties´ that renders one or multiple empty property rows with custom title and value.

These changes was done to mimic the functionality in the workorders app ´PlannedScreen´

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants