Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create settings screen component #197

Closed
wants to merge 6 commits into from

Conversation

Sandtory
Copy link
Contributor

Added settingsscreen template.
Merged main into mad-screens.

@Sandtory Sandtory linked an issue Sep 13, 2023 that may be closed by this pull request
1 task
@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023

🦋 Changeset detected

Latest commit: 32596bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/mad-screens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Sandtory Sandtory changed the title 190 create settings screen component feat: create settings screen component Sep 13, 2023
@tormodAase
Copy link
Contributor

This PR fails some checks. Let me know when those are resolved! Then I will start the review @Sandtory

Copy link
Collaborator

@HaakonSvane HaakonSvane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌍 -> 🎱
If you shrunk down our planet earth to the size of a billlard ball, the earth would be more smooth than the billiard ball. Still, not as smooth as your code 😎

apps/chronicles/navigation/LinkingConfiguration.ts Outdated Show resolved Hide resolved
apps/chronicles/navigation/index.tsx Outdated Show resolved Hide resolved
apps/chronicles/screens/TemplateScreen.tsx Outdated Show resolved Hide resolved
packages/screens/src/SettingsTemplate/SettingsTemplate.tsx Outdated Show resolved Hide resolved
packages/screens/src/SettingsTemplate/SettingsTemplate.tsx Outdated Show resolved Hide resolved
packages/screens/src/SettingsTemplate/SettingsTemplate.tsx Outdated Show resolved Hide resolved
packages/screens/src/SettingsTemplate/SettingsTemplate.tsx Outdated Show resolved Hide resolved
packages/screens/src/SettingsTemplate/SettingsTemplate.tsx Outdated Show resolved Hide resolved
@Sandtory
Copy link
Contributor Author

If my code was a burning building and you were a firefighter, consider my code extinguished 🔥🚒

@tormodAase
Copy link
Contributor

@Sandtory should we close this? Since Settings Screen already has been added?

@Sandtory
Copy link
Contributor Author

yes was thinking the same, can be closed @tormodAase

@Sandtory Sandtory closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Settings screen component
3 participants