Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv_export only tested within gui #7921

Open
yngve-sk opened this issue May 16, 2024 · 0 comments
Open

csv_export only tested within gui #7921

yngve-sk opened this issue May 16, 2024 · 0 comments

Comments

@yngve-sk
Copy link
Contributor

yngve-sk commented May 16, 2024

If the any underlying logic of csv export, as done in ert/workflows/jobs/internal-gui/scripts/csv_export.py:run fails or throws an error, it will cause the gui test for csv export (test_csv_export.py) to just hang, waiting for some qt thing to never appear. Since it mostly goes into storage, it is "vulnerable" to changes in storage leading to just another hanging gui test, without it being obvious why. This is also an unfortunate mixing of business logic which is "backend" into the frontend, ideally (personal opinion) there is more of a separation

Proposed solutions (pick one, which one is the better is up for discussion)

  1. Test the logic of csv export (contents of ert/workflows/jobs/internal-gui/scripts/csv_export.py:run) separately, the test can just do the same as the current one: Run poly and export with the same settings as is default in the GUI.
  2. Make the errors from "gui plugins" surface more explicitly so the gui tests don't hang forever
  3. Make the gui test somehow not hang and to stop if an error surfaces from the csv export logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant