Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typeddict in ert.gui.model.snapshot #7883

Open
jonathan-eq opened this issue May 13, 2024 · 1 comment · May be fixed by #8051
Open

Use typeddict in ert.gui.model.snapshot #7883

jonathan-eq opened this issue May 13, 2024 · 1 comment · May be fixed by #8051
Assignees
@jonathan-eq
Labels
improvement Something nice to have, that will make life easier for developers or users or both.

Comments

@jonathan-eq
Copy link
Contributor

The SnapshotModel class has a dict called metadata, which should be a dataclass instead to improve readability.
@jonathan-eq jonathan-eq added the improvement Something nice to have, that will make life easier for developers or users or both. label May 13, 2024
@jonathan-eq jonathan-eq self-assigned this May 13, 2024
@jonathan-eq jonathan-eq mentioned this issue May 14, 2024
Closed
9 tasks
@jonathan-eq jonathan-eq linked a pull request Jun 4, 2024 that will close this issue
Open
9 tasks
@jonathan-eq
Copy link
Contributor Author

Changing this issue to use TypedDict instead of dataclass, so we dont have to turn the dictionaries received over websockets into the dataclass, and then back to dict.

@jonathan-eq jonathan-eq changed the title Use dataclasses in ert.gui.model.snapshot Use ~dataclasses~ typeddict in ert.gui.model.snapshot Jun 4, 2024
@jonathan-eq jonathan-eq changed the title Use ~dataclasses~ typeddict in ert.gui.model.snapshot Use ~~dataclasses~~ typeddict in ert.gui.model.snapshot Jun 4, 2024
@jonathan-eq jonathan-eq changed the title Use ~~dataclasses~~ typeddict in ert.gui.model.snapshot Use ~~~dataclasses~~~ typeddict in ert.gui.model.snapshot Jun 4, 2024
@jonathan-eq jonathan-eq changed the title Use ~~~dataclasses~~~ typeddict in ert.gui.model.snapshot Use ~dataclasses typeddict in ert.gui.model.snapshot Jun 4, 2024
@jonathan-eq jonathan-eq changed the title Use ~dataclasses typeddict in ert.gui.model.snapshot Use ~ dataclasses ~ typeddict in ert.gui.model.snapshot Jun 4, 2024
@jonathan-eq jonathan-eq changed the title Use ~ dataclasses ~ typeddict in ert.gui.model.snapshot Use typeddict in ert.gui.model.snapshot Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathan-eq jonathan-eq

Labels
improvement Something nice to have, that will make life easier for developers or users or both.
Projects
SCOUT
Status: Ready for Review
Milestone
No milestone
1 participant
@jonathan-eq