Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor object from Pydantic to dataclass #7879

Open
berland opened this issue May 13, 2024 · 1 comment · May be fixed by #7915
Open

Refactor object from Pydantic to dataclass #7879

berland opened this issue May 13, 2024 · 1 comment · May be fixed by #7915
Assignees
@jonathan-eq
Labels
improvement Something nice to have, that will make life easier for developers or users or both.

Comments

@berland
Copy link
Contributor

berland commented May 13, 2024

dataclass should be more lightweight, and the weight of Pydantic is probably not needed for this object:

ert/src/ert/scheduler/lsf_driver.py

Line 89 in bd52a37

class JobData(BaseModel):

@berland berland added the improvement Something nice to have, that will make life easier for developers or users or both. label May 13, 2024
@jonathan-eq jonathan-eq self-assigned this May 16, 2024
@jonathan-eq jonathan-eq linked a pull request May 16, 2024 that will close this issue
Open
9 tasks
@jonathan-eq
Copy link
Contributor

Related to #7938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathan-eq jonathan-eq

Labels
improvement Something nice to have, that will make life easier for developers or users or both.
Projects
SCOUT
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Lsf driver to use dataclasses jonathan-eq/ert
2 participants
@berland @jonathan-eq