Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code patching for reading vehicles #220

Open
sebhoerl opened this issue Mar 5, 2024 · 1 comment
Open

Code patching for reading vehicles #220

sebhoerl opened this issue Mar 5, 2024 · 1 comment

Comments

@sebhoerl
Copy link
Contributor

sebhoerl commented Mar 5, 2024

Currently, data.vehicles.raw performs some patching of openpyxl, but the mock library is not in our conda environment.

Solution 1

  • Add mock to the environment

Solution 2

  • Check if there is a newer version of openpyxl
  • Update in our environment
  • Check if it works without patching and with the newer version

Solution 3

  • It seems that the error is related to malformatted data. Maybe if we use the most recent data sets, the problem has even solved itself?
  • Test by simply removing the call to mock.
@sebhoerl sebhoerl mentioned this issue Mar 5, 2024
2 tasks
@sebhoerl
Copy link
Contributor Author

We also do some monkey patching on openpxyl for reading the urban typology data. So I guess simply adding mock to the dependencies is fine. Need to figure out which version and update environment.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant