Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Replaces Own Validator type with PropTypes.Validator #393

Open
daniel-nagy opened this issue Apr 29, 2024 · 1 comment
Open

[Bug] Replaces Own Validator type with PropTypes.Validator #393

daniel-nagy opened this issue Apr 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@daniel-nagy
Copy link

Hi,

I just used the types-react-codemod@latest preset-19 per the TypeScript Changes in the React 19 upgrade guide and it replaced my own Validator type in one of my files with PropTypes.Validator.

Not a big deal but thought I would report it. Thanks for the codemod!
@eps1lon
Copy link
Owner

eps1lon commented Apr 29, 2024

Yeah I cheated here a bit and just looked for Validator without actually checking if it comes from react. Would love to see a fix from somebody but I won't have time to prioritize this.

@eps1lon eps1lon added the enhancement New feature or request label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daniel-nagy @eps1lon