152 friendly connection error messages #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GeraldineGomez I will make some more changes before sending it again to you |
GeraldineGomez
requested changes
May 20, 2024
There was a problem hiding this comment.
Hi @jpavlich,
Thank you so much for tackling this issue 😊. I think the messages are very clear and friendly for the user. I made some minor comments.
GeraldineGomez
approved these changes
May 23, 2024
…most connection errors and sends a friendly message before stopping
…with `tryCatch` if connection fails
…n the 5-second limit at CRAN
- Corrected small syntax errors on the examples of `plot_tabla_incidencia_geo`, `plot_tabla_incidencia_sex` - Added `\donttest` to functions that connect to the network: `import_data_incidencia`, `import_data_event`
jpavlich
force-pushed
the
152-friendly-connection-error-messages
branch
from
8d3b73c
to
0b524a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152
I used
tryCatchsince it is the recommended way to catch errors inhttr2https://httr2.r-lib.org/reference/req_error.htmland it is used in functions that should abort when the connection fails