Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make truncation adjusted distributions the default? #243

Closed
adamkucharski opened this issue Feb 14, 2024 · 1 comment
Closed

Make truncation adjusted distributions the default? #243

adamkucharski opened this issue Feb 14, 2024 · 1 comment
Milestone

Comments

@adamkucharski
Copy link
Member

Currently the default seems to be providing the distribution with "right_truncated": false (or perhaps just the first that appears in the database. For example:

onset_to_death_period_in <-
  epiparameter::epidist_db(disease = "covid",epi_dist = "onset to death",single_epidist = T)
  
print(onset_to_death_period_in$summary_stats)

Returns the distribution from Linton et al with mean 14.5, rather than the more accurate distribution that adjusts for right truncation with mean 20.2. One option would be to have user define this if they want truncation adjustment (e.g. for case studies like this in EpiNow2), but given it is almost always preferable, probably better to just provide automatically?

@joshwlambert
Copy link
Member

I agree that because in most cases the truncation adjusted entries will be preferable, when available, I have updated epidist_db() to select them when specifying single_epidist = TRUE in PR #323.

The order of preference when single_epidist = TRUE is now:

  1. subset to the entries that are parameterised
  2. subset to the entries that have truncation adjustment (new addition in Select truncation adjusted library entry with epidist_db() #323)
  3. select entry with the largest sample size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants