Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Think about range_long_to_quantile() #444

Closed
nikosbosse opened this issue Nov 15, 2023 · 2 comments · Fixed by #798
Closed

Think about range_long_to_quantile() #444

nikosbosse opened this issue Nov 15, 2023 · 2 comments · Fixed by #798
Labels
low-priority
Milestone
scoringutils-2.0

Comments

@nikosbosse
Copy link
Contributor

The function range_long_to_quantile() was previously used in score_quantile(). It transforms forecasts from a long interval format to a quantile format.

Depending on whether we want to support the interval format in the future (see #443), the function should either

  • be deleted
  • be renamed, e.g. to something like interval_long_to_quantile (following the naming of the function quantile_to_interval()
This was referenced Nov 15, 2023
Closed
Merged
@nikosbosse nikosbosse added this to the scoringutils 2.x milestone Dec 5, 2023
@seabbs
Copy link
Contributor

seabbs commented Apr 12, 2024

If we aren't using this we should remove it for now I think?

@nikosbosse
Copy link
Contributor Author

Good catch. I moved this to the current release.

@nikosbosse nikosbosse mentioned this issue Apr 21, 2024
Merged
9 tasks
nikosbosse added a commit that referenced this issue May 12, 2024
@nikosbosse
Merge pull request #798 from epiforecasts/range_long_to_quantile
1166149 
Issue #444 - Remove `interval_long_to_quantile` (previously `range_long_to_quantile`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-priority
Projects
scoringutils 2.0
Status: Done
Milestone
scoringutils-2.0
2 participants
@seabbs @nikosbosse