Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_forecast_unit() and friends customisable such that they can work with new forecast classes #740

Open
nikosbosse opened this issue Mar 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nikosbosse
Copy link
Contributor

nikosbosse commented Mar 24, 2024

get_forecast_unit() currently relies on an internal call to get_protected_columns() to identify which columns it should ignore. These are currently things like quantile_level and sample_id.

This all works well within the current package. But once you start adding new classes then maybe that won't work so well anymore. I think what we should do is add a protected_columns argument to get_forecast_unit() and friends such that you could manually define which columns are protected. Similarly for set_forecast_unit(). Probably as_forecast() needs a ... arg.

Not proposing we do that now, but if we're serious about allowing users to write their custom classes, then we should likely do that at some point.
(get_forecast_type() may be another candidate for some additional tweaking, as well as the collapse argument for get_forecast_counts())

@nikosbosse nikosbosse added the enhancement New feature or request label Mar 24, 2024
@nikosbosse nikosbosse added this to the scoringutils-2.x milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant