Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish NA (missing) from NA (accumulated) #547

Open
sbfnk opened this issue Feb 14, 2024 · 3 comments
Open

Distinguish NA (missing) from NA (accumulated) #547

sbfnk opened this issue Feb 14, 2024 · 3 comments

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Feb 14, 2024

Enabling this would, I think, require some sort of that marks dates explicitly as missing vs. NA.

I think this would be my preferred option as it would be more general but I also think it can be addressed in its own review as it would be a superset of this PR.

My thought on how that would work is to have a new variable (accumulate) that indicates which days should be summed.

Originally posted by @seabbs in #534 (review)

@sbfnk
Copy link
Contributor Author

sbfnk commented Feb 14, 2024

My thought on how that would work is to have a new variable (accumulate) that indicates which days should be summed.

Another option would be to distinguish between explicit (date exists in the data, value is NA meaning missing) vs. implicit (date doesn't exist in the data meaning accumulate) NAs which might be easier preprocessing if potentially easier to inadvertently get wrong.

@seabbs
Copy link
Contributor

seabbs commented Feb 19, 2024

yeah potentially but also think that could be a bit dangerous. I would instead suggest making a helper function that maps from that structure to the less dangerous explicit version for those that clearly want that.

@seabbs
Copy link
Contributor

seabbs commented Feb 19, 2024

and if going that way I'd suggest that becomes a dependent issue

@sbfnk sbfnk added this to the CRAN v1.6 release milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants