Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot json support #151

Closed
heifner opened this issue Apr 27, 2022 · 4 comments · Fixed by AntelopeIO/leap#24
Closed

snapshot json support #151

heifner opened this issue Apr 27, 2022 · 4 comments · Fixed by AntelopeIO/leap#24
Assignees
Labels
3.2 Candidate enhancement New feature or request OCI OCI working this issue...

Comments

@heifner
Copy link
Member

heifner commented Apr 27, 2022

EOSIO/eos#11058 added option to convert snapshots to JSON.
The output format should be changed slightly from what is in that PR so that the resulting JSON can be more easily read.
Along with 11058, should add the ability to read in the JSON. We have rapid JSON dependency already, so rather straightforward to add read of the JSON.

@matthewdarwin matthewdarwin added the enhancement New feature or request label Apr 27, 2022
@spoonincode
Copy link
Member

Personally I'd like to see this not be lumped in to nodeos. We have an eosio-blocklog tool that does all things blocklog, similarly I could see an eosio-snapshot tool that does all things snapshot.

For example I'd like to be able to eosio-snapshot --blocknum snapshot.bin and just get a simple block number on stdout. With nodeos I'm going to get all sorts of log spam in the output making it a pain to integrate with scripts etc

@heifner
Copy link
Member Author

heifner commented Apr 28, 2022

We have talked about a eosio-util for awhile. I do think we want --snapshot of nodeos to accept either .bin or .json files.

@spoonincode
Copy link
Member

What is the benefit to having nodeos accept a snapshot in json form?

@heifner
Copy link
Member Author

heifner commented May 4, 2022

You can easily modify the JSON snapshot and then read it into nodeos updating its state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2 Candidate enhancement New feature or request OCI OCI working this issue...
Projects
Status: Done
4 participants