You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two major issue:
1 topics: [] should mean any topic (effectively filter out nothing) but now it will filter out everything as it cannot find any matches to null.
2 topics filter should follow such role: https://ethereum.org/en/developers/docs/apis/json-rpc/
A note on specifying topic filters: Topics are order-dependent. A transaction with a log with topics [A, B] will be matched by the following topic filters:
[] "anything"
[A] "A in first position (and anything after)"
[null, B] "anything in first position AND B in second position (and anything after)"
[A, B] "A in first position AND B in second position (and anything after)"
[[A, B], [A, B]] "(A OR B) in first position AND (A OR B) in second position (and anything after)"
We may need a major refactor of related silkworm code to fix the second issue.
But for the first one, it can be handled by a special case easily. We MUST fix this because web3.js IS sending that empty topics array by default.....
The first part, which was the more critical one to fix, was already resolved by #378.
This issue is meant to track the second part which will be more complicated to fix. There is no plan to fix that prior to launch but it seems the deficiency is not a major problem for existing EOS EVM users.
The text was updated successfully, but these errors were encountered:
From #377 by @yarkinwho:
The first part, which was the more critical one to fix, was already resolved by #378.
This issue is meant to track the second part which will be more complicated to fix. There is no plan to fix that prior to launch but it seems the deficiency is not a major problem for existing EOS EVM users.
The text was updated successfully, but these errors were encountered: