Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request adding token description / tags / website / github and socials #628

Open
Wapaca opened this issue Apr 21, 2024 · 3 comments

Comments

@Wapaca
Copy link

Wapaca commented Apr 21, 2024

Current tokens.json format is

{
    "name": "<NAME>",
    "logo": "https://raw.githubusercontent.com/eoscafe/eos-airdrops/master/logos/<SYMBOL>.png",
    "logo_lg": "https://raw.githubusercontent.com/eoscafe/eos-airdrops/master/logos/<SYMBOL>.png",
    "symbol": "<SYMBOL>",
    "account": "<CONTRACT NAME>",
    "chain": "<chain>"
}

How about adding complementary fields for other data like website, a descript, tags github .... ?

See example on Alcor repo here https://github.com/avral/alcor-ui/blob/master/assets/fundamentals/wax.json

I wish all those data were directly standard inside the eosio.token contract (even the small logo, it would be few kB of ram) but that's another topic.

@DenisCarriere
Copy link
Collaborator

It's definitely an option to add some extra fields

However, it would require some work to update the existing tokens, there would be a lot of missing data for the existing tokens.

Not sure if it's worth adding all that extra effort for those extra fields when so many of the tokens will be missing metadata

@Wapaca
Copy link
Author

Wapaca commented Apr 22, 2024

It could be without updating existing tokens as those fields aren't mandatory, updating the example from the README might makes new PR include those information.

Right now even for logo i need to download from both eoscafe + alcor-ui to get all.

@DenisCarriere
Copy link
Collaborator

Wouldn't be a bad idea, have some required fields and optional fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants