Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: fix failing tests with mismatched renderer #2113

Open
ljharb opened this issue Apr 25, 2019 · 10 comments · May be fixed by #2122
Open

hooks: fix failing tests with mismatched renderer #2113

ljharb opened this issue Apr 25, 2019 · 10 comments · May be fixed by #2122

Comments

@ljharb
Copy link
Member

ljharb commented Apr 25, 2019

There's a few tests failing, currently marked as allowed failures in 3db6013, that shouldn't be failing.

Ideally, the functionality can be fixed; if not, then the tests should be skipped when the breakages are expected.

@ljharb ljharb added this to Needs Triage in React 16 via automation Apr 25, 2019
@ljharb ljharb moved this from Needs Triage to v16.8+: Hooks in React 16 May 4, 2019
@AlokTakshak
Copy link

@ljharb I would like to work on it can you explain what all needs to be done?

@ljharb
Copy link
Member Author

ljharb commented May 6, 2019

@AlokTakshak sure! I'm not exactly sure what needs to be done to fix it; but basically, remove these two test jobs from allowed_failures in travis.yml, and then fix the react 16 adapter so the tests pass :-)

@AlokTakshak
Copy link

@ljharb is it closed now?

@ljharb
Copy link
Member Author

ljharb commented May 10, 2019

@AlokTakshak no, those jobs are still allowed failures.

@AlokTakshak
Copy link

AlokTakshak commented May 11, 2019

@ljharb i am running test cases in my local it is passing, i think someones changes fixed the issue
image
image

@ljharb
Copy link
Member Author

ljharb commented May 11, 2019

In that case, a PR that solely removes the allowed failures would close this issue :-)

@AlokTakshak
Copy link

@ljharb yeah Sure i will raise it ASAP

@AlokTakshak
Copy link

#2122

@AlokTakshak
Copy link

AlokTakshak commented May 11, 2019

@ljharb
npm run test:all
for me it is passing in local but not in travis
I have tried for a specific version that also works fine
npm run react 16.8
npm run build
npm test

@ljharb
Copy link
Member Author

ljharb commented May 11, 2019

You have to use the RENDERER env var with npm run react if you want to replicate what happens in Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
React 16
  
v16.8+: Hooks
Development

Successfully merging a pull request may close this issue.

2 participants