Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Tracing #326

Open
ethernoy opened this issue Apr 12, 2022 · 7 comments
Open

Support Tracing #326

ethernoy opened this issue Apr 12, 2022 · 7 comments

Comments

@ethernoy
Copy link
Contributor

I am experiencing some difficulty when troubleshooting a slow ratelimit installation. I believe adding tracing of any format (preferrably zipkin or openTelemetry) to the ratelimit service can be of great help.

Happy to submit a PR if this is ok.

@mattklein123
Copy link
Member

Sure, though I would go straight to Open Telemetry.

@ethernoy
Copy link
Contributor Author

Sure, though I would go straight to Open Telemetry.

Great, then let me work on it

@ethernoy
Copy link
Contributor Author

Sure, though I would go straight to Open Telemetry.

@mattklein123 Have a question in mind: if we are going to send out OTEL span when calling memcached and redis, it probably needs the caller to pass the parent traceId in gRPC request body, which isn't around for now according to the proto file in envoyproxy project:

https://github.com/envoyproxy/envoy/blob/main/api/envoy/service/ratelimit/v2/rls.proto
https://github.com/envoyproxy/envoy/blob/main/api/envoy/service/ratelimit/v3/rls.proto

Should we consider to add such data in the ratelimit request protocol? Also we will need to add the implementation in envoyproxy in order to produce a full trace.

@mattklein123
Copy link
Member

Yeah we can add this to the API for sure.

@ethernoy
Copy link
Contributor Author

Yeah we can add this to the API for sure.

Nice, then let me finish the implementation from ratelimit side first

@zirain
Copy link

zirain commented Apr 18, 2023

@ChezCrawford
Copy link

Can we close this if it was taken care of by #332 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants