Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support metadata input in Mathching API #34092

Open
zhaohuabing opened this issue May 10, 2024 · 4 comments
Open

Support metadata input in Mathching API #34092

zhaohuabing opened this issue May 10, 2024 · 4 comments
Assignees
@vikaschoudhary16
Labels
area/matching enhancement Feature requests. Not bugs or questions.

Comments

@zhaohuabing
Copy link
Member

zhaohuabing commented May 10, 2024 •
edited

Title: Support metadata input in Matching API

Description:
The Matching API currently doesn't support Metata Input. It would be valuable if Envoy could support it.

For instance, we prefer using Matcher over RBAC rules for authorization due to its flexibility. However, while RBAC allows specifying metadata as the principal, the matcher API currently lacks this capability, limiting use cases such as JWT claims as principals.

The supported Matching Inputs: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/advanced/matching/matching_api#extension-category-envoy-matching-http-input

@arkodg
@zhaohuabing zhaohuabing added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels May 10, 2024
@kyessenov
Copy link
Contributor

Sure, this would be a great addition, and can follow similar code to filter state input.

@zhaohuabing zhaohuabing mentioned this issue May 10, 2024
Open
@vikaschoudhary16
Copy link
Contributor

Hey @zhaohuabing Are you working to implement it?

@zhaohuabing
Copy link
Member Author

Hey @zhaohuabing Are you working to implement it?

No, feel free to go ahead if you get time.

@ravenblackx ravenblackx added area/matching and removed triage Issue requires triage labels May 13, 2024
@vikaschoudhary16
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vikaschoudhary16 vikaschoudhary16

Labels
area/matching enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zhaohuabing @ravenblackx @kyessenov @vikaschoudhary16