Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RateLimitQuotaIntegrationTest.TwoRequestWithTokenBucketThrottling is flakey (TIMEOUT) #34041

Closed
phlax opened this issue May 9, 2024 · 2 comments · Fixed by #34043
Closed

RateLimitQuotaIntegrationTest.TwoRequestWithTokenBucketThrottling is flakey (TIMEOUT) #34041

phlax opened this issue May 9, 2024 · 2 comments · Fixed by #34043
Assignees
@tyxia
Labels
area/test flakes

Comments

@phlax
Copy link
Member

phlax commented May 9, 2024 •
edited

This test was added in #33921

as that PR was addressing a different flake im reluctant to revert, but the test takes a very long time and ci analytics gives it a 0% pass rate

image

https://dev.azure.com/cncf/envoy/_build/results?buildId=170010&view=logs&j=767be981-567e-57d8-68c3-2140ede0a0bd&t=2181edf2-f610-59f2-c43a-04bb9d0bca00&l=457
@tyxia
Copy link
Member

tyxia commented May 9, 2024

The newly added test is flaky actually due to the same reason: pending stats implementation

I am thinking that remove the newly added test and lower the coverage threshold for RLQS

@phlax
Copy link
Member Author

phlax commented May 9, 2024

thanks @tyxia - probably we should do that as apart from failing its taking a long time

perhaps we should add a ticket re RLQS coverage?

@tyxia tyxia mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyxia tyxia

Labels
area/test flakes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RLQS: fix the flaky test tyxia/envoy
2 participants
@phlax @tyxia