Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support typed dynamic filter metadata in access loggers #33975

Open
nezdolik opened this issue May 6, 2024 · 2 comments
Open

Support typed dynamic filter metadata in access loggers #33975

nezdolik opened this issue May 6, 2024 · 2 comments
Labels
area/access_log enhancement Feature requests. Not bugs or questions.

Comments

@nezdolik
Copy link
Member

nezdolik commented May 6, 2024

Title: Support typed dynamic filter metadata in access loggers

Description:
Nowadays access logger supports formatters for dynamic filter metadata, e.g. %DYNAMIC_METADATA(NAMESPACE:KEY*):Z%, but as the adoption of typed filter metadata will increase across Envoy filters, we need to introduce support for typed filter metadata in the access logger extension.

Relevant Links
Current use case where proxy protocol filter sets typed filter metadata and could benefit from access logger's support for such type of data.

@nezdolik nezdolik added enhancement Feature requests. Not bugs or questions. triage Issue requires triage area/access_log labels May 6, 2024
@phlax
Copy link
Member

phlax commented May 8, 2024

cc @ggreenway @soulxu

@phlax phlax removed the triage Issue requires triage label May 8, 2024
@cpakulski
Copy link
Contributor

So, the goal is to "understand" a syntax of typed dynamic metadata, correct? In other words, the formatter should know how to display a dynamic metadata based on its type, instead of dumping that metadata in generic way.

Btw, there is new METADATA formatter: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/formatter/metadata/v3/metadata.proto#envoy-v3-api-msg-extensions-formatter-metadata-v3-metadata, which I put as an extension, but am planning to bring it back into core as core formatter. That new formatter will eventuall obsolete multiple *_METADATA formatters: #33004.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/access_log enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

3 participants