You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Title: Support OpenTelemetry Resource detectors for Otel Metrics sink
Description: The OpenTelemetry project defines the concept of a Resource. It is a bag of attributes that can be configured in different ways in OpenTelemetry, via environment variables, explicitly in code or via Resource detectors.
However, the OpenTelemetry Logger implementation, while allowing configurable resource attributes does not support resource detectors.
The OpenTelemetry Metrics sink does not seem to support allowing configurable resource attributes - not even service.name (please correct me if I'm wrong).
The OpenTelemetry Resource concept applies across all telemetry signals - traces, metrics and logs. It would be great to see if we can unify the different signal types in Envoy such that the OpenTelemetry Resource configuration is specified once, and then inherited by the three different signal generators.
Failing that, at least unifying support for each signal type to be able to specify a set of resource detectors (specifically the Environment Resource Detector which can set resource attributes from environment variables as defined in the OpenTelemetry specification) would greatly help in identifying the metrics and logs as emanating from the same underlying Envoy instance.
Relevant Links: #28929 - Adding Resource Detectors to OpenTelemetry Tracer
The text was updated successfully, but these errors were encountered:
I didn't dig into details of how OTel metrics and logs are collected/recorded in Envoy. This would be another benefit if we would use the OTel SDK in Envoy instead of having a somewhat custom implementation of it.
Having said that, maybe it's possible to "move out" the concept of resource detector from the tracer package/module so other signals can be used? I'm not sure if that's possible..
Title: Support OpenTelemetry Resource detectors for Otel Metrics sink
Description: The OpenTelemetry project defines the concept of a Resource. It is a bag of attributes that can be configured in different ways in OpenTelemetry, via environment variables, explicitly in code or via Resource detectors.
Issue #28929 and its resolution #29547 added support in the OpenTelemetry Tracer configuration for "Resource Detectors".
However, the OpenTelemetry Logger implementation, while allowing configurable resource attributes does not support resource detectors.
The OpenTelemetry Metrics sink does not seem to support allowing configurable resource attributes - not even
service.name
(please correct me if I'm wrong).The OpenTelemetry Resource concept applies across all telemetry signals - traces, metrics and logs. It would be great to see if we can unify the different signal types in Envoy such that the OpenTelemetry Resource configuration is specified once, and then inherited by the three different signal generators.
Failing that, at least unifying support for each signal type to be able to specify a set of resource detectors (specifically the Environment Resource Detector which can set resource attributes from environment variables as defined in the OpenTelemetry specification) would greatly help in identifying the metrics and logs as emanating from the same underlying Envoy instance.
Relevant Links: #28929 - Adding Resource Detectors to OpenTelemetry Tracer
The text was updated successfully, but these errors were encountered: