Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry metrics sink and access logger - Ability to configure OpenTelemetry Resource via Resource Detectors #33970

Open
evantorrie opened this issue May 6, 2024 · 3 comments
Labels
area/opentelemetry enhancement Feature requests. Not bugs or questions.

Comments

@evantorrie
Copy link

Title: Support OpenTelemetry Resource detectors for Otel Metrics sink

Description: The OpenTelemetry project defines the concept of a Resource. It is a bag of attributes that can be configured in different ways in OpenTelemetry, via environment variables, explicitly in code or via Resource detectors.

Issue #28929 and its resolution #29547 added support in the OpenTelemetry Tracer configuration for "Resource Detectors".

  1. However, the OpenTelemetry Logger implementation, while allowing configurable resource attributes does not support resource detectors.

  2. The OpenTelemetry Metrics sink does not seem to support allowing configurable resource attributes - not even service.name (please correct me if I'm wrong).

The OpenTelemetry Resource concept applies across all telemetry signals - traces, metrics and logs. It would be great to see if we can unify the different signal types in Envoy such that the OpenTelemetry Resource configuration is specified once, and then inherited by the three different signal generators.

Failing that, at least unifying support for each signal type to be able to specify a set of resource detectors (specifically the Environment Resource Detector which can set resource attributes from environment variables as defined in the OpenTelemetry specification) would greatly help in identifying the metrics and logs as emanating from the same underlying Envoy instance.

Relevant Links: #28929 - Adding Resource Detectors to OpenTelemetry Tracer

@evantorrie evantorrie added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels May 6, 2024
@phlax
Copy link
Member

phlax commented May 8, 2024

cc @AlexanderEllis @htuch

@phlax phlax added area/opentelemetry and removed triage Issue requires triage labels May 8, 2024
@phlax
Copy link
Member

phlax commented May 8, 2024

cc @joaopgrassi

@joaopgrassi
Copy link
Contributor

I didn't dig into details of how OTel metrics and logs are collected/recorded in Envoy. This would be another benefit if we would use the OTel SDK in Envoy instead of having a somewhat custom implementation of it.

Having said that, maybe it's possible to "move out" the concept of resource detector from the tracer package/module so other signals can be used? I'm not sure if that's possible..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/opentelemetry enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

3 participants