Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable GuardDogImpl #2581

Open
jpsim opened this issue Sep 29, 2022 · 2 comments
Open

Disable GuardDogImpl #2581

jpsim opened this issue Sep 29, 2022 · 2 comments
Assignees
@jpsim

Comments

@jpsim
Copy link
Contributor

jpsim commented Sep 29, 2022

https://github.com/envoyproxy/envoy/blob/main/source/server/guarddog_impl.cc

The purpose of this type is to terminate the current process (generally an Envoy server) if the system isn't healthy.

We should never do this in a mobile app setting, so we should just turn this off when building Envoy Mobile.
@jpsim jpsim mentioned this issue Sep 29, 2022
Closed
@jpsim
Copy link
Contributor Author

jpsim commented Sep 29, 2022

Envoy PR: envoyproxy/envoy#23316

@jpsim jpsim self-assigned this Sep 29, 2022
@jpsim jpsim mentioned this issue Sep 29, 2022
Closed
@jpsim
Copy link
Contributor Author

jpsim commented Sep 30, 2022

Hmmm, I think the watch dog is currently responsible for actually running the main dispatch loop, so to disable it I'll actually need to run the main dispatch loop some other way.
I've marked the Envoy PR as being a draft until I can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpsim jpsim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow disabling the guard dog
build: disable guard dog envoyproxy/envoy-mobile
1 participant
@jpsim