Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing of Socket Tagging code #2494

Open
RyanTheOptimist opened this issue Aug 23, 2022 · 0 comments
Open

Improve testing of Socket Tagging code #2494

RyanTheOptimist opened this issue Aug 23, 2022 · 0 comments

Comments

@RyanTheOptimist
Copy link
Contributor

Support for Android socket tagging is added in PR #2423. However, the test coverage is not ideal. Chromium's unit tests for the socket tagging implementation looks at /proc to check that traffic was actually tagged. The current Envoy Mobile test environment runs with #ifdef(ANDROID_API) false so such tests aren't really possible.

Once we have support for running tests in an Android environment #2450, we should makes use of this capability to improve socket tagging tests.
@RyanTheOptimist RyanTheOptimist mentioned this issue Aug 23, 2022
Merged
RyanTheOptimist added a commit that referenced this issue Aug 23, 2022
@RyanTheOptimist @Augustyniak
Add a filter for applying Android socket tags (#2423)
66ecf9f 
Add a filter for applying Android socket tags

Testing: Functionality verified as part of the run of the experimentation example app. Also filed #2494 to track improvements.
Docs Changes: Updated docs/root/api/starting_envoy.rst
Release Notes: Added

Signed-off-by: Ryan Hamilton <rch@google.com>
Co-authored-by: Rafał Augustyniak <Augustyniak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RyanTheOptimist