Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiping does not work on iOS 5 #20

Open
pcevandijk opened this issue Aug 9, 2011 · 13 comments
Open

Swiping does not work on iOS 5 #20

pcevandijk opened this issue Aug 9, 2011 · 13 comments

Comments

@pcevandijk
Copy link

Im currently testing my apps on iOS 5 and see a problem when using the EGOPhotoViewer in landscape mode.
The swiping between photos does not work anymore in landscape. All works fine in portrait.

Update 1: I looked in to it somewhat further and discovered that it only does not work if you try to swipe touching the photo's but if you use any black areas next to the photo it works fine.
Seems the scrollViewDidScroll events are nog coming when swiping the photo in landscape modus.

Update 2: If i disable the userInteraction of the EGOPhotoImageView it all works fine. But then you dont receive push events and cant hide / show the toolbars.

@agonych
Copy link

agonych commented Sep 23, 2011

Seems the issue happens because of two UIScrollView conflicting - script use one to establish scrolling between images and another to make zoom-in/zoom-out. On some images this construction fails. A simple workaround would be to modify EGOPhotoScrollView.h:

  1. in function initWithFrame change self.scrollEnabled = NO;
  2. in function zoomRectWithCenter change first "if" as shown:

if (self.zoomScale > 1.0f) {
self.scrollEnabled = NO;
[((EGOPhotoImageView*)self.superview) killScrollViewZoom];
return;
}
self.scrollEnabled = YES;

@pcevandijk
Copy link
Author

Thanks man, works like a charm.

@jpm
Copy link

jpm commented Oct 18, 2011

This worked great here. The problem was really only happening on a very small subset of pictures.

@futuretap
Copy link

Thanks, works great!

@AndreyPanov
Copy link

Thx! You save my project :)

@mickeyl
Copy link

mickeyl commented Feb 16, 2012

Awesome, agonych! Thumbs up for you.

@agonych
Copy link

agonych commented Feb 16, 2012

You might as well consider to use Three20 library (http://three20.info/) which is newer and have a photo gallery module.

@mickeyl
Copy link

mickeyl commented Feb 17, 2012

Ya, thanks, I know three20, but the I prefer EGOPhotoViewer since it has fewer dependencies.

@agonych
Copy link

agonych commented Feb 17, 2012

Well, EGOPhotoViewer seems to be no longer developed

@passerbycrk
Copy link

Thanks

@Abeansits
Copy link

W0W! Thanks a bunch for this. What I don't understand is why this is an issue for only a few photos?
The only common denominator is that they are fullscreen photos, but it is not true for all full screen photos though.

@lancep
Copy link

lancep commented May 17, 2012

Sweet! this helped me as well! sure wish the owner of the repo would patch this so in the future everyone gets this fix

@appmake
Copy link

appmake commented May 9, 2013

Thnx!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants