Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] Selector labels are not unique among deamonsets #265

Open
sboschman opened this issue Mar 20, 2024 · 0 comments
Open

[Helm] Selector labels are not unique among deamonsets #265

sboschman opened this issue Mar 20, 2024 · 0 comments
Assignees
Labels
bug Something isn't working helm

Comments

@sboschman
Copy link

The Helm chart allows you to define multiple daemonsets, which each a unique name. The (pod) selector for all daemonsets is the same though:

{{/*
Selector labels
*/}}
{{- define "x509-certificate-exporter.selectorLabels" -}}
app.kubernetes.io/name: {{ include "x509-certificate-exporter.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
{{- end -}}

Which links every pod to every daemonsets, which is a but unfortunate.

Perhaps we can use the app.kubernetes.io/component label to differentiate between pods from different daemonsets?
(add app.kubernetes.io/component to the spec.selector.matchLabels set and to spec.template.metadata.labels set)

As the chart already supports podExtraLabels per daemonset, another option would be to add some sort of extraSelectorLabels option and let the chart user create unique selector labels.

@paullaffitte paullaffitte added bug Something isn't working helm labels Apr 2, 2024
@paullaffitte paullaffitte self-assigned this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm
Projects
None yet
Development

No branches or pull requests

2 participants