Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short JSON files need to be deleted!!! #2369

Open
k0T0z opened this issue Nov 22, 2023 · 2 comments
Open

Short JSON files need to be deleted!!! #2369

k0T0z opened this issue Nov 22, 2023 · 2 comments

Comments

@k0T0z
Copy link
Contributor

k0T0z commented Nov 22, 2023

This is related to patch #2335 and issue #1951.

I found out that for the same input, there are multiple different outputs!!!

For example:

[ [ 1 , 2 ] , 2 ]

This can be converted to:

{
  " 0 ": {
    " 0 ": 1,
    " 1 ": 2
  },
  " 1 ": 2
}

OR

[
  {
    " 0 ": 1,
    " 1 ": 2
  },
  2
]

OR

[
  [
    1,
    2
  ],
  2
]

OR

{
  " 0 ": [
    1,
    2
  ],
  " 1 ": 2
}

They are all valid JSONs!!!

This needs to be discussed but I think the discussion will end up with these files deleted anyway:

short_json.cpp, short_json.h, short_json_converter.cpp, and short_json_converter.h.

@saihaankhan12
Copy link

Hi, I would like to work on this issue. Could you pls assign it to me?

@k0T0z
Copy link
Contributor Author

k0T0z commented Jan 23, 2024

Hello @saihaankhan12, we don't assign issues feel free to open a talk about this issue on ENIGMA's official discord server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants