Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssetArray class doesn't support pointers #2366

Open
k0T0z opened this issue Nov 15, 2023 · 5 comments
Open

AssetArray class doesn't support pointers #2366

k0T0z opened this issue Nov 15, 2023 · 5 comments

Comments

@k0T0z
Copy link
Contributor

k0T0z commented Nov 15, 2023

The AssetArray class needs to support pointers.

For example, this line

AssetArray<LeaderboardFindResult_t*> leaderboards_array;
fails.

@k0T0z k0T0z changed the title Asset array class doesn't support pointers AssetArray class doesn't support pointers Nov 30, 2023
@sidling1
Copy link
Contributor

sidling1 commented Mar 7, 2024

The AssetArray.h file contains the following lines :

template<typename T, int LEFT = 0>
class AssetArray

I think this should not produce errors if LeaderboardFindResult_t* is a valid type

Can you guide me on how to reproduce this error ?

@k0T0z
Copy link
Contributor Author

k0T0z commented Mar 7, 2024

You can reproduce it by uncommenting this line gc_leaderboards_score_downloaded_cookies.cpp#L109 or gc_leaderboards_find_result_cookies.cpp#L58 or gc_leaderboards_score_uploaded_cookies.cpp#L62. I am not familiar with this class anyway, it is mentioned by Robert on the community. Robert is not available at the moment, though.

R0bert — 29/09/2023 18:58
that error is pretty simple though, yeah assetarray don't handle pointers yet

@sidling1
Copy link
Contributor

sidling1 commented Apr 7, 2024

I have tried to uncomment these lines, but i face no issues / failure. Is this issue fixed ?

@k0T0z
Copy link
Contributor Author

k0T0z commented Apr 7, 2024

@sidling1 You should use the leaderboard API to reproduce the crash

@sidling1
Copy link
Contributor

sidling1 commented Apr 7, 2024

In the Steamwork demo game, I used the Leaderboard part, which uses the Leaderboard API ig.

I even put Debug Messages around these lines, and they ran without any problem/ error showing up, and the debug messages showed normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants