New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect way of enabling stub extensions #2362
Comments
@k0T0z @JoshDreamland is there any advantage by implementing this change i see only 2 extensions in the makefile . |
@evil-user this is a sort of technical debt payoff; it's not as though this issue will kill us, which is why we marked it a "Good First Issue" and left it alone. It's just a little bit of an ugly hack in the way we do makefiles. As Saif said, the better way is to do |
@evil-user As Josh said, I have nothing to add. The 2nd main purpose of this change is to reduce the number of changes needed for the makefile as making too many changes is error-prone. Also, note that I removed these two lines inside my last PR #2363: compile_game: $(STEAM_FAKE_LIB)
clean: steam_clean to be: ifeq (,$(findstring Universal_System/Extensions/Steamworks, $(EXTENSIONS)))
include Universal_System/StubExtensions/Steamworks/Makefile
endif So Steamworks extension is not a special case anymore. |
@JoshDreamland @k0T0z So how in makefile can I test the changes, I tried to learn it, but was not able to understand it |
@Daksh-10 You will have to try to build ENIGMA with all those extensions that have a stub enabled, which are basically: DataStructure and Steamworks. Also, you may have to build Steamworks from that branch ( |
@k0T0z, about this issue I found some things, So, is there anything I can do now. (Also there were reasons why I was not contributing, which we can discuss on discord) |
I want to contribute your issue please approach me |
Currently, when you need to enable a stub for an extension, you will have to create a separate code for it inside the Engine makefile like here:
enigma-dev/ENIGMAsystem/SHELL/Makefile
Lines 133 to 136 in 3918af3
and here:
enigma-dev/ENIGMAsystem/SHELL/Makefile
Lines 124 to 131 in 3918af3
This is incorrect and unnecessary, I would like to loop over all the extensions and enable its stub if the extension is disabled and the stub exists.
The text was updated successfully, but these errors were encountered: