Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining issues / test points for AstGeneration integration #2316

Open
8 tasks
JoshDreamland opened this issue Aug 19, 2022 · 0 comments
Open
8 tasks

Remaining issues / test points for AstGeneration integration #2316

JoshDreamland opened this issue Aug 19, 2022 · 0 comments

Comments

@JoshDreamland
Copy link
Member

JoshDreamland commented Aug 19, 2022

This is a list of items to verify before we can merge the AstGeneration branch into master. We should test on a variety of games, but in particular, these items are important:

  • "Global local" variable access (e.g. inst.x + inst.yglaccess(inst)->x + glaccess(inst)->y)
  • Custom variable access (inst.foovaraccess_foo(inst))
  • With-statement scoping (implicit variable access for locals referenced in with() statements)
  • Functions accepting enigma::varargs
  • Function accepting enigma_this
  • Use of event_inherited()
  • Global and local variable declaration (global int some_global;, local int some_local;)
  • Instance creation code (particularly without use of with_room_inst, which was used historically for code applying to deactivated instances)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant