support multiple include query params #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,5 @@ | |||
| export default function (includes) { | |||
| export default function (input) { | |||
| const includes = Array.isArray(input) ? input : input.split(','); | |||
There was a problem hiding this comment.
This doesn't account for if the value is an object, which could happen with ?include[thing]=x&include[otherthing]=y
There was a problem hiding this comment.
There was a problem hiding this comment.
Indeed! He actually wrote this algo, too :)
|
any chances of this getting merged? |
|
@sgraham785 are you interested in being a collaborator on this repo and landing/publishing this yourself? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also needs to be taken into account for all other params (esp sort). Just opening this so the solution is ready.
More generally, I need to write unit tests for the whole request handler and we need an integration test for this behavior /cc @bobholt.
closes gh-129