Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to extract the password values efficiently #46

Open
kmmanoj opened this issue Feb 9, 2020 · 1 comment
Open

Unable to extract the password values efficiently #46

kmmanoj opened this issue Feb 9, 2020 · 1 comment

Comments

@kmmanoj
Copy link

kmmanoj commented Feb 9, 2020

I ran the main function to extract credentials as :
$ ./SlackPirate.py --token xoxs-xxxxxxxx --credential-scan
the harvested credentials were successfully written to ./<folder>/passwords.txt

Meanwhile, in my private experimental slack workspace I have the following messages in the #general channel.
Screen Shot 2020-02-09 at 3 19 16 PM

I expected the password.txt file to contain these credentials, but what I found in it is:

password is "abcdef"',
password is "abcdef"'}]}]}],
password is"',
@emtunc
Copy link
Owner

emtunc commented Mar 27, 2020

I tested your PR and it found the examples you gave but missed other test ones in my test Slack channels. More work to be done here to improve the credential check for sure.

For now, I have made a very minor adjustment to the regex so that it finds the examples you gave above: db340f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants