Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make guidemaker service more flexible #89

Open
BlueCutOfficial opened this issue May 26, 2023 · 0 comments · May be fixed by #90
Open

Make guidemaker service more flexible #89

BlueCutOfficial opened this issue May 26, 2023 · 0 comments · May be fixed by #90

Comments

@BlueCutOfficial
Copy link

Currently, guidemaker service defines fixed properties like title or logo out of the environment config. It restricts the possibility of customizations when using guidemaker in a custom guidemaker's template.

It would be nice to make guidemaker service act as a simple proxy to access the config, so we can do for instance:

my-app/config/environement.js

module.exports = function (environment) {
  let ENV = {
    guidemaker: {
      title: 'My app built with guidemaker',
      customProp: 'a property I need to customize my guidemaker template'
    }
  }
}
<!-- my-guidemaker-template/templates/application.hbs -->

{{this.guidemaker.customProp}}

We have a first use case with guidemaker-ember-locale-template-ember-fr-guides-source pair: we use a mascots property to prepare the use of locale mascots, and we'll probably use some new properties to customize the footer and maybe other layout elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant