Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] the canonical url is not being built correctly #144

Open
mansona opened this issue Nov 6, 2021 · 2 comments
Open

[BUG] the canonical url is not being built correctly #144

mansona opened this issue Nov 6, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@mansona
Copy link
Member

mansona commented Nov 6, 2021

There is something strange going on with the canonical URL for posts. There is a test that should be covering this https://github.com/empress/empress-blog/blob/master/tests/acceptance/meta-test.js#L40-L41 but if you look at the source of https://blog.emberjs.com/the-ember-times-issue-190/ the canonical should be https://blog.emberjs.com/the-ember-times-issue-190/ but it's actually https://blog.emberjs.comthe-ember-times-issue-190/. This isn't just for the ember blog it seems to be every deployment: https://chris.manson.ie/it's-all-gravy has the same issue

@gnclmorais
Copy link

Is this still happening? The images on your personal blog seem to be working find… 🤔

@mansona
Copy link
Member Author

mansona commented Apr 28, 2022

So there is a chance that this was fixed when I fixed this #145 but I would like to be 100% sure before closing this issue. It looks like the canonical on the ember blog is still broken so maybe it just needs an update?

@mansona mansona added good first issue Good for newcomers and removed help wanted labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants