Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded comment section? #116

Open
elwayman02 opened this issue Apr 7, 2021 · 1 comment
Open

Embedded comment section? #116

elwayman02 opened this issue Apr 7, 2021 · 1 comment

Comments

@elwayman02
Copy link
Contributor

Has there been any thought given to allowing discussions to take place at the bottom of articles, as is common for blogs? We could integrate a free, open platform like Disqus, which would offload the need for any sort of database/server or the ability to have the app write back to the repo to "save" comments. Since any third-party platform would require some sort of key to specify what account/community/site it's hooked up to, that could easily be done in the configuration of empress-blog itself to make it an opt-in feature.

@mansona
Copy link
Member

mansona commented Apr 17, 2021

so there has been some thought to it for sure, the only thing that isn't quite settled is the API for something like this.

My current idea is that we would have some sort of addon that you would need to install for a particular comment infrastructure, that way it would decouple the comment implementation from the template itself and have the same addon work in any template hopefully without much further tweaking.

This idea is inspired by the template that empress-blog-casper-template is based on, and you can actually still see some of the code in the template files: https://github.com/empress/empress-blog-casper-template/blob/master/app/templates/post.hbs#L66

There is also an example of a comments component in the ember-blog template: https://github.com/ember-learn/empress-blog-ember-template/blob/master/app/templates/post.hbs#L21 and https://github.com/ember-learn/empress-blog-ember-template/blob/master/addon/components/comments.hbs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants