Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octane-ify Templates #38

Open
elwayman02 opened this issue Jan 25, 2021 · 0 comments
Open

Octane-ify Templates #38

elwayman02 opened this issue Jan 25, 2021 · 0 comments

Comments

@elwayman02
Copy link
Contributor

elwayman02 commented Jan 25, 2021

Many of the route templates use a mish-mash of classic and Octane syntax. Some cleanup here would be nice, as well as enabling linting rules to enforce Octane patterns.

Example: https://github.com/empress/empress-blog-casper-template/blob/master/app/templates/post.hbs#L98

A few of the issues:

  • {{link-to}} instead of <LinkTo>
  • ambiguous paths due to implicit this usage
  • {{svg-icons/infinity}} instead of <SvgIcons::Infinity>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant