Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate benchmarks from tests #105

Open
weikengchen opened this issue Dec 27, 2020 · 1 comment
Open

Separate benchmarks from tests #105

weikengchen opened this issue Dec 27, 2020 · 1 comment

Comments

@weikengchen
Copy link
Contributor

This is related to the high overhead of CI.

It appears that certain tests in the repo are closer to a benchmark than a test.

A good example is here:

	for (long long length = 2; length <= 8192; length*=2) {
		long long times = 1024*1024*32/length;
		block * data = new block[length+1];
		char * data2 = (char *)data;
		auto start = clock_start();
		for (int i = 0; i < times; ++i) {
			prg.random_data(data2, length*16);
			//prg.random_data_unaligned(data2+1, length*16);
		}
		double interval = time_from(start);
		delete[] data;
		cout << "PRG speed with block size "<<length<<" :\t"<<(length*times*128)/(interval+0.0)*1e6*1e-9<<" Gbps\n";
	}

This is left as a future todo. It is also challenging to think about what tests would give us good coverage.

@wangxiao1254
Copy link
Member

github action added, with a self-hosted machine for ARM. I think one option is to take the test size as input. That will solve the problem. (I don't want too many files:P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants