Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max-width in the css #132

Open
FredM67 opened this issue Jun 7, 2021 · 2 comments
Open

Remove max-width in the css #132

FredM67 opened this issue Jun 7, 2021 · 2 comments

Comments

@FredM67
Copy link

FredM67 commented Jun 7, 2021

I cannot see any advantage to set a max width for any view. When displayed on a "big" monitor (for me 1920x1200), the view is displayed on about 66% of the width of the screen. Why?
When I remove this parameter at the beginning of the css file (or set it to a much bigger value), the view takes the whole window width.

Same apply for other views...

@glynhudson
Copy link
Member

Agree, I don't see the need for the restriction. The Feeds/Inputs pages can scale to any width.

@TrystanLea is there a reason for this restriction?

Emoncms - graph 192 - Google Chrome_442
Emoncms - feed view - Google Chrome_443

@chaveiro
Copy link
Contributor

chaveiro commented Oct 7, 2021

This is a good question and i've removed on #137 but it seems the 1150px magic number is across many EmonCMS modules, maybe due to historic reasons.
What was behind that? Can we remove it everywhere ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants