Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review UI improvements suggested by DJ Jones #1799

Open
TrystanLea opened this issue May 10, 2022 · 0 comments
Open

Review UI improvements suggested by DJ Jones #1799

TrystanLea opened this issue May 10, 2022 · 0 comments

Comments

@TrystanLea
Copy link
Member

TrystanLea commented May 10, 2022

See: https://community.openenergymonitor.org/t/at-emoncms-org-my-graphs-default-to-1-week-no-matter-what-i-save-as/20453

Post content:

If I create fresh Graphs I observe this:

  • first time I click graph menu - the default is an empty graph, set to show '1 week'.
  • I select an existing graph - it shows it with the correct time frame (from last save I made earlier in the week - 24 hours) - BUT the menu still says 1 week.
  • in fact -when you move between existing graphs in the edit - the Menu will NOT change between graphs. Even tho each may show a different time-line in the graph itself.
  • if you change the menu - it then 'sticks' with that, as you again move between saved Graphs.

So two code tweaks - does this sound right?
A) when displaying the Dashboard - set the menu for each graph to the same time-range as the graph already knows about and displays
B when editing Graphs - when move to another pre-saved graph - change the menu to match what the graph already knows about and displays.

II) I have another tiny UI tweak (no code to change): - in emonCMS.org when adding graphs to dashboard -the setting for /width/height can be changed between 'pixels' and 'percent' - with 'pixel' as default.
It would be more logical to default to 'percent' for the width - to make it responsive on both mobile phone narrow screens and on desktop screens.
And maybe add some text on that config page to explain that).

III) And ANOTHER UI tweak for emonCMS -that does need code

  • as above when a graph has width as 'percentage' - the calculations are somehow wrong: if in editing you pull the graph to be nearly full width - when you save and look at the live dashboard - on some screen widths the graph overlaps the end -so you miss-off the Y axis.
    Maybe some CSS is not understanding maybe there's not 100% of the page width, available to the graph object.
  • maybe this applies to any objects that can be set to be 'width= percentage'?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant