Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to create custom relabelling config for serviceMonitor #5510

Open
raghavtan opened this issue Jan 12, 2024 · 0 comments
Open

Add support to create custom relabelling config for serviceMonitor #5510

raghavtan opened this issue Jan 12, 2024 · 0 comments
Labels
t:feature New feature or enhancement request

Comments

@raghavtan
Copy link

raghavtan commented Jan 12, 2024

Please describe your use case / problem.
I want to be able to use custom relabelling for all prometheus metrics exported by emissary. Since we use the upstream chart and just customise it using the values.yaml

Describe the solution you'd like
Update to the helm-chart templates: Extra variable metrics.serviceMonitor.relabelings and templating toggle in the serviceMonitor template
This will allow us to add extra labels to prometheus metrics exposed by addition to scrape_config for the job

Describe alternatives you've considered
Using mutating web-hook to update the serviceMonitor spec after deployment but since we use argocd reconciler it is reverted by argocd which can also be ignored. But this is too wide of a workaround for support to add custom config for serviceMonitor

Additional context
Add any other context about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:feature New feature or enhancement request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants