Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RawMessage::unpack so that it doesn't panic on invalid messages #10

Open
eminence opened this issue Jul 16, 2022 · 1 comment
Open

Comments

@eminence
Copy link
Owner

In RawMessage::unpack, we are doing a bunch of asserts to make sure that the incoming bytes are expected. These asserts will panic, which is not great. Instead, we should convert these assertions into normal if checks that return errors

@eminence
Copy link
Owner Author

If anyone wants to work on this, let me know. It could be a good first issue to get familiar with the code. I'll probably tackle this myself in about a week, to chime in if you want to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant