Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links are not working in description element #408

Open
wottpal opened this issue Apr 30, 2024 · 3 comments
Open

Links are not working in description element #408

wottpal opened this issue Apr 30, 2024 · 3 comments

Comments

@wottpal
Copy link

wottpal commented Apr 30, 2024

Example:

  toast.success('Success', {
    description: `View <a href="https://google.com" target="_blank">Google</a>`,
  })

The link is rendering correctly and is detected by Chrome, but it isn't clickable. I assume some wrapper is preventing event propagation. 🤔

@bkilrain
Copy link

bkilrain commented May 1, 2024

Looks like it's been fixed but not released yet #378

@wottpal
Copy link
Author

wottpal commented May 1, 2024

Looks like it's been fixed but not released yet #378

Actually I've checked out that issue and it's not the same. The html/node is rendering correctly if passed as a string. Even the links, they are just not clickable.

Though, I would say I find the way of passing nodes as strings and having them internally sanitized & rendered very counter intuitive, error-prone, and restrictive. Why not just using JSX.Element here, @emilkowalski? 🤔

@gurvirsinghbaraich
Copy link

Hi @wottpal,
I found the issue interesting and when I reproduced the issue the link seems work properly. I believe there might be some issue with the CSS styles that you might have applied to the element or it's parent.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants