New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve capability of toast `action`/`cancel` customization #397

Closed

6thpath opened this issue Apr 6, 2024 · 0 comments · Fixed by #398

Contributor

6thpath commented Apr 6, 2024

I believe it would be easier for consumer to custom the toast dismiss action by making toast action/cancel

action label property accepts ReactNode instead of string only
action onClick property should be optional

in some case I only need to pass cancel: { label: <some-svg /> } to create my own toast dismiss button

The text was updated successfully, but these errors were encountered:

6thpath mentioned this issue

feat: updates toast action/cancel property type/handlers #398

Merged

3 tasks

emilkowalski closed this as completed in #398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment