Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove repeat effect hook to resolve mix up #392

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tzyito
Copy link

@Tzyito Tzyito commented Apr 2, 2024

Issue:

fix #391

What has been done:

useEffect and useLayoutEffect both listen to toast.id and include the same logic, so remove the repeated calls to cancel the duplicate toast array

Screenshots/Videos:

Kapture 2024-04-02 at 11 29 40

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 4:13am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【Bug】hover shake when the toasts's position is changed
1 participant