Optimize Entity.WriteTo when encoding/charset are unchanged #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 79.49% 79.70% +0.20%
==========================================
Files 15 15
Lines 995 1005 +10
==========================================
+ Hits 791 801 +10
Misses 128 128
Partials 76 76
Continue to review full report at Codecov.
|
|
This doesn't work if |
foxcpp
reviewed
Apr 29, 2020
Comment on lines
+124
to
+125
| } else if w.encoding == e.encoding && w.charset == e.charset { | ||
| _, err = io.Copy(w.rawWriter, e.originalBody) |
There was a problem hiding this comment.
Perhaps then this branch can also check whether e.Body was replaced by the user? Or, add a getter/setter pair for Body that will invalidate originalBody.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #86