Regression on app-js order/shadowing

[simonihmig]

We are using ember-cli-sentry (v1 addon, and yes, I know it's old and deprecated), and an internal (v2!) addon that is overriding the former's instance-initializers/raven-setup.js (using app-js). To ensure its own initializer takes precedence, it has explicitly this meta data in its package.json:

  "ember": {
    "edition": "octane",
    "after": [
      "ember-cli-sentry"
    ]
  },

This works fine in a classic build: only the internal addon's initializer is invoked, shadowing the one from ember-cli-sentry.

But when switching to Embroider (v3), this regresses: the initializer from ember-cli-sentry is called. The internal addon's one is not even in the bundle AFAICT. Same applies for the service. Changing after to before also makes no difference.

I believe we didn't see this when the internal addon was still v1 based, but not entirely sure.

[simonihmig]

@patricklx pointed my to ./node_modules/.embroider/resolver.json#activeAddons, which lists our internal addon before ember-cli-sentry, and that does not change when I change ember.after to before.

[simonihmig]

For the record, this issue has been discussed a bit on Discord, and @ef4 has a hunch that the ordering might not be correct for native v2 addons, see https://discord.com/channels/480462759797063690/1237465816199593994/1237466743715266703