Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can a compat app keep all of the unprocessed app/styles/ files? #1878

Open
raycohen opened this issue Apr 14, 2024 · 1 comment
Open

Can a compat app keep all of the unprocessed app/styles/ files? #1878

raycohen opened this issue Apr 14, 2024 · 1 comment

Comments

@raycohen
Copy link
Contributor

I have a legacy app building with embroider, but I needed to move my app/styles/ contents to another folder to be able to apply custom loaders to it, since the styles folder is excluded from the rewritten app.

At this point I'm not using the legacy app/styles/ behavior at all (I import the app-level styles from app.js), but I'd like to be able to keep my source files in app/styles/ to avoid the diffs from moving them to an arbitrary other folder name that isn't as good as "styles".

From #1033 (comment)

... you couldn't keep your scss in app/styles -- that path gets enough legacy handling that it doesn't just flow through normally to where webpack can see it.

Basically the question is, do we want to prevent use of the app/styles/ folder for webpack-based use?

@ef4
Copy link
Contributor

ef4 commented Apr 15, 2024

I think it would be good to add a flag that disables the classic style pipeline for app/styles. It does not exist right now but it could.

We'd probably still want addons to be able to use the classic style pipeline even when the app opts out. That would be a separate flag for when you're sure no old addon needs it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants