Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to control order of addon implicit styles? #1862

Open
raycohen opened this issue Apr 2, 2024 · 1 comment · May be fixed by #1866
Open

Ability to control order of addon implicit styles? #1862

raycohen opened this issue Apr 2, 2024 · 1 comment · May be fixed by #1866

Comments

@raycohen
Copy link
Contributor

raycohen commented Apr 2, 2024

In a classic build, my addons css was being concatenated into vendor.css in alphabetical order based on package name, which I think is a result of file system behavior once their individual processed css files are merged into a folder.

With embroider, I'm getting a very different order that I don't fully understand. I tried using package.json "ember-addon"."before"/"after" config which didn't seem to have any impact.

I have a very large monorepo with ~100 addons, so migrating fully off of implicit styles would be a large effort. But with the changed css order we've found issues where same-specificity rules changed order and a different one is taking precedence with embroider than with classic.

Is there any way to control the order that I'm missing?

@ef4
Copy link
Contributor

ef4 commented Apr 4, 2024

vendor.css is intended as a backward compatibility feature so if it's not producing the same order that's a bug.

@raycohen raycohen linked a pull request Apr 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants